Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy argument to Array.__array__ #20077

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Add copy argument to Array.__array__ #20077

merged 1 commit into from
Mar 5, 2024

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Mar 5, 2024 •
edited
Loading

This is used by NumPy 2.0, and will be required in a future numpy version (see numpy/numpy#25941).

Part of #19246

@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Mar 5, 2024
@jakevdp jakevdp self-assigned this Mar 5, 2024
@jakevdp jakevdp requested a review from yashk2810 March 5, 2024 17:33
@copybara-service copybara-service bot merged commit 32fec82 into jax-ml:main Mar 5, 2024
12 of 13 checks passed
@jakevdp jakevdp deleted the fix-dunder-array branch March 5, 2024 18:54
copybara-service bot pushed a commit that referenced this pull request Mar 5, 2024
Rollback #20077
7c25337 
Reverts 32fec82

PiperOrigin-RevId: 612990220
@copybara-service copybara-service bot mentioned this pull request Mar 5, 2024
Closed
copybara-service bot pushed a commit that referenced this pull request Mar 5, 2024
Rollback #20077
5dad49f 
Reverts 32fec82

PiperOrigin-RevId: 612990220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashk2810 yashk2810 yashk2810 approved these changes

Assignees

@jakevdp jakevdp

Labels
kokoro:force-run pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakevdp @yashk2810